[bugfix] Do not reset sourcesdir to None if it is set to a URL
#1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjotero
changed the title
sourcesdir reset when it is not a directory.
Contributor
|
Hmm, this behaviour is a feature actually. Here is the feature request, if I remember correctly: #1094. |
vkarak
changed the title
sourcesdir reset when it is not a directory.sourcesdir reset when it is not a directory.
Contributor
Contributor
Author
I think that should be fixed now. But I guess that we should move all the stuff that affects the vars to a post-init hook in the future. |
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 49 49
Lines 8395 8395
=======================================
Hits 7374 7374
Misses 1021 1021
Continue to review full report at Codecov.
|
teojgo
approved these changes
Mar 18, 2021
vkarak
changed the title
sourcesdir reset when it is not a directory.sourcesdir to None if it is set to a URL
vkarak
approved these changes
Mar 18, 2021
Contributor
|
@jenkins-cscs retry daint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the pipeline's
_rfm_init, wheresourcesdirwas reset toNoneif the directory didn't exist. Consequently, whensourcesdiris a git repo and is set in the class body,_rfm_initwould just reset it toNone.