Skip to content

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Apr 20, 2021

Closes #1938

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the collection completely.

@vkarak vkarak added this to the ReFrame sprint 21.04.2 milestone Apr 20, 2021
@vkarak vkarak changed the title [ci] remove collections for alps [ci] Remove module collections for Alps config Apr 20, 2021
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 21, 2021

When I run:

class XTest_new(rfm.CompileOnlyRegressionTest):
    m = parameter(['cray-mpich/8.1.4'])

I get:

  * Reason: key error: 'collection'
Traceback (most recent call last):
  File "/users/piccinal/reframe.git/reframe/frontend/executors/__init__.py", line 269, in _safe_call
    return fn(*args, **kwargs)
  File "/users/piccinal/reframe.git/reframe/core/hooks.py", line 36, in _fn
    func(obj, *args, **kwargs)
  File "/users/piccinal/reframe.git/reframe/core/pipeline.py", line 97, in _wrapped
    return fn(*args, **kwargs)
  File "/users/piccinal/reframe.git/reframe/core/pipeline.py", line 1250, in compile
    trap_errors=True
  File "/users/piccinal/reframe.git/reframe/core/schedulers/__init__.py", line 364, in prepare
    builder.write(runtime.emit_loadenv_commands(*environs))
  File "/users/piccinal/reframe.git/reframe/core/runtime.py", line 237, in emit_loadenv_commands
    _, commands = loadenv(*environs)
  File "/users/piccinal/reframe.git/reframe/core/runtime.py", line 224, in loadenv
    m, mod['collection'], mod['path'],
KeyError: 'collection'

{'name': 'PrgEnv-gnu', 'collection': False} works around it

@vkarak
Copy link
Contributor

vkarak commented Apr 21, 2021

When I run:

class XTest_new(rfm.CompileOnlyRegressionTest):
    m = parameter(['cray-mpich/8.1.4'])

I get:

  * Reason: key error: 'collection'
Traceback (most recent call last):
  File "/users/piccinal/reframe.git/reframe/frontend/executors/__init__.py", line 269, in _safe_call
    return fn(*args, **kwargs)
  File "/users/piccinal/reframe.git/reframe/core/hooks.py", line 36, in _fn
    func(obj, *args, **kwargs)
  File "/users/piccinal/reframe.git/reframe/core/pipeline.py", line 97, in _wrapped
    return fn(*args, **kwargs)
  File "/users/piccinal/reframe.git/reframe/core/pipeline.py", line 1250, in compile
    trap_errors=True
  File "/users/piccinal/reframe.git/reframe/core/schedulers/__init__.py", line 364, in prepare
    builder.write(runtime.emit_loadenv_commands(*environs))
  File "/users/piccinal/reframe.git/reframe/core/runtime.py", line 237, in emit_loadenv_commands
    _, commands = loadenv(*environs)
  File "/users/piccinal/reframe.git/reframe/core/runtime.py", line 224, in loadenv
    m, mod['collection'], mod['path'],
KeyError: 'collection'

{'name': 'PrgEnv-gnu', 'collection': False} works around it

I think this is a bug. Can you open one?

The 'collection': False is not the "right" workaround. You don't need to use dictionaries. Just define the the modules in the classic way:

'modules': ['PrgEnv-gnu']

@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 22, 2021

#1943

@codecov-commenter
Copy link

Codecov Report

Merging #1939 (7b43c7f) into master (1ba2f7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1939   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          50       50           
  Lines        8620     8620           
=======================================
  Hits         7577     7577           
  Misses       1043     1043           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba2f7f...7b43c7f. Read the comment docs.

@vkarak vkarak changed the title [ci] Remove module collections for Alps config [ci] Remove module collections from Alps config Apr 22, 2021
@vkarak vkarak merged commit e725c07 into reframe-hpc:master Apr 22, 2021
@jgphpc jgphpc deleted the jg/alps branch April 22, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove module collection from cscs config

4 participants