Skip to content

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented May 25, 2021

closes #1854

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #1985 (308295f) into master (e893946) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
+ Coverage   87.52%   87.59%   +0.06%     
==========================================
  Files          50       50              
  Lines        8731     8770      +39     
==========================================
+ Hits         7642     7682      +40     
+ Misses       1089     1088       -1     
Impacted Files Coverage Δ
reframe/core/pipeline.py 91.62% <0.00%> (+0.04%) ⬆️
reframe/core/buildsystems.py 96.59% <0.00%> (+0.38%) ⬆️
reframe/utility/typecheck.py 95.45% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e893946...308295f. Read the comment docs.

Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I think we should add a line mentioning the --dont-restage option, too.

@vkarak vkarak changed the title [doc] Add tutorial to debug sanity patterns [doc] Add tutorial about debugging sanity and performance patterns May 26, 2021
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak requested a review from teojgo May 26, 2021 21:01
@vkarak vkarak merged commit 1ff3a77 into reframe-hpc:master May 27, 2021
@jjotero jjotero deleted the doc/tips-and-tricks-update branch May 27, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion - add command-line option to only run sanity/performance checks

4 participants