Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Oct 19, 2021

Fixes #2226

@teojgo teojgo added this to the ReFrame sprint 21.10.1 milestone Oct 19, 2021
@teojgo teojgo requested review from ekouts and vkarak October 19, 2021 13:11
@teojgo teojgo self-assigned this Oct 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #2229 (51e0106) into master (07c7182) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 51e0106 differs from pull request most recent head 502327d. Consider uploading reports for the commit 502327d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2229   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files          55       55           
  Lines        9746     9746           
=======================================
  Hits         8337     8337           
  Misses       1409     1409           
Impacted Files Coverage Δ
reframe/frontend/cli.py 76.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c7182...502327d. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the problem is that we auto detect the system too early here:

https://github.com/eth-cscs/reframe/blob/e9ec5b94d62a7f2f8b413c296cc866271ef2546e/reframe/frontend/cli.py#L618

We should instead do that after we process the --detect-host-topology option, just before this line:

https://github.com/eth-cscs/reframe/blob/e9ec5b94d62a7f2f8b413c296cc866271ef2546e/reframe/frontend/cli.py#L677

Can you try that out?

@teojgo
Copy link
Contributor Author

teojgo commented Oct 20, 2021

I think that the problem is that we auto detect the system too early here:

https://github.com/eth-cscs/reframe/blob/e9ec5b94d62a7f2f8b413c296cc866271ef2546e/reframe/frontend/cli.py#L618

We should instead do that after we process the --detect-host-topology option, just before this line:

https://github.com/eth-cscs/reframe/blob/e9ec5b94d62a7f2f8b413c296cc866271ef2546e/reframe/frontend/cli.py#L677

Can you try that out?

Yes this does the trick.

@vkarak vkarak merged commit 3f70d2b into reframe-hpc:master Oct 20, 2021
@teojgo teojgo deleted the bugfix/remote_autodetect_infinite branch November 25, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote autodetection leads to spawning of many jobs

4 participants