[bugfix] Remove timeout argument from git clone command
#2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use timeout to git_clone function only to check if repo exists. We should not use it in actual git clone <url> command. Timeout argument to git clone command is remove and documentation is adapted
Collaborator
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 55 55
Lines 9754 9754
=======================================
Hits 8344 8344
Misses 1410 1410
Continue to review full report at Codecov.
|
Contributor
|
Ok to test |
jjotero
suggested changes
Oct 26, 2021
Contributor
jjotero
left a comment
jjotero
left a comment
There was a problem hiding this comment.
Some minor cosmetic changes
We change name of git_clone_timeout variable to git_timeout as we use this timeout only to check if repo exists. Documentation is modified accordingly.
jjotero
approved these changes
Oct 26, 2021
teojgo
approved these changes
Oct 26, 2021
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
Lgtm, I have tested with some actual example and it works fine.
vkarak
approved these changes
Oct 27, 2021
vkarak
changed the title
git clone command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
timeoutargument ingit_clonefunction only to check if repo exists. We should not use it in actualgit clone <url>command. Timeout argument togit clonecommand is removed and documentation is adapted.Fixes #2238