[bugfix] Fix type error when RFM_GIT_TIMEOUT is set
#2243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casting the git_timeout var into float to avoid errors when env var RFM_GIT_TIMEOUT is set which is str type
Codecov Report
@@ Coverage Diff @@
## master #2243 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 55 55
Lines 9754 9754
=======================================
Hits 8344 8344
Misses 1410 1410
Continue to review full report at Codecov.
|
Collaborator
|
Can I test this patch? |
vkarak
approved these changes
Oct 28, 2021
Contributor
|
Ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting the
git_timeoutvar into float to avoid errors when env varRFM_GIT_TIMEOUTis set which isstrtype.Fixes #2237