[feat] Define the execution order of hooks and implement it properly #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2021 11:15
Hooks are now executed in reverse MRO order.
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 56 56
Lines 10202 10205 +3
=======================================
+ Hits 8787 8790 +3
Misses 1415 1415
Continue to review full report at Codecov.
|
teojgo
requested changes
Nov 19, 2021
teojgo
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #2268 the order of execution of inherited hooks was not documented and it was also wrong. This PR solves this issue by imposing a reverse MRO execution order, so that the hooks of the most specialized class are executed last. In the part, hooks were executed starting from the derived classes going up to the bases, but without following strict MRO order.
Fixes #2268.