Skip to content

[feat] Support passing arbitrary options to git clone in the git_clone() utility function #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2021
Merged

[feat] Support passing arbitrary options to git clone in the git_clone() utility function #2279

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
803ae90
Add opts support to git_clone func
mahendrapaipuri Nov 22, 2021
961fb35
Use `opts=None` instead of `[]`
mahendrapaipuri Nov 22, 2021
3aa78f3
Merge branch 'master' into feature/add-opts-git-clone
Nov 22, 2021
01e6da4
Update `git_clone` docstring
mahendrapaipuri Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions reframe/utility/osext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,11 @@ def is_url(s):
return parsed.scheme != '' and parsed.netloc != ''


def git_clone(url, targetdir=None, timeout=5):
def git_clone(url, targetdir=None, opts=None, timeout=5):
'''Clone a git repository from a URL.

:arg url: The URL to clone from.
:arg opts: List of options to be passed to the `git clone` command
:arg timeout: Timeout in seconds when checking if the url is a valid
repository.
:arg targetdir: The directory where the repository will be cloned to. If
Expand All @@ -429,7 +430,8 @@ def git_clone(url, targetdir=None, timeout=5):
raise ReframeError('git repository does not exist')

targetdir = targetdir or ''
run_command(f'git clone {url} {targetdir}', check=True)
opts = ' '.join(opts) if opts is not None else ''
run_command(f'git clone {opts} {url} {targetdir}', check=True)


def git_repo_exists(url, timeout=5):
Expand Down