Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 24, 2021

This was practically introduced because we blindly reversed the order of hooks in RegressionTest.pipeline_hooks(). Now the reverse MRO order is ensured as we build the global hook registry of the class. Since the local registries of the parent classes are used to update this class' registry, the order of their hooks as they are inserted is preserved.

Fixes #2284.

@vkarak vkarak added this to the ReFrame sprint 21.11.2 milestone Nov 24, 2021
@vkarak vkarak requested review from ekouts and teojgo November 24, 2021 20:23
@vkarak vkarak self-assigned this Nov 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #2287 (bd4c5ae) into master (30346e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2287   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files          56       56           
  Lines       10206    10208    +2     
=======================================
+ Hits         8790     8792    +2     
  Misses       1416     1416           
Impacted Files Coverage Δ
reframe/core/hooks.py 90.00% <100.00%> (+0.22%) ⬆️
reframe/core/meta.py 98.80% <100.00%> (ø)
reframe/core/pipeline.py 92.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30346e0...bd4c5ae. Read the comment docs.

@vkarak vkarak merged commit 9bd98ce into reframe-hpc:master Nov 25, 2021
@vkarak vkarak deleted the bugfix/hook-exec-order-same-class branch November 25, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in execution order of hooks within same stage in same class

4 participants