Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Nov 18, 2022

To be honest I like a bit more the original solution of @rsarm , using the utility of scontrol instead of maintaining our own nodelist_expand. I did the minimum changes and haven't updated the unittests to discuss first what you think.

Fixes #2677

@ekouts ekouts requested review from rsarm and vkarak November 18, 2022 07:21
@ekouts ekouts self-assigned this Nov 18, 2022
@ekouts ekouts marked this pull request as draft November 18, 2022 07:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Base: 86.37% // Head: 86.36% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6af68b2) compared to base (53aad83).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
- Coverage   86.37%   86.36%   -0.02%     
==========================================
  Files          60       60              
  Lines       11114    11115       +1     
==========================================
- Hits         9600     9599       -1     
- Misses       1514     1516       +2     
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 53.33% <33.33%> (-0.15%) ⬇️
reframe/frontend/executors/policies.py 92.50% <0.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vkarak vkarak marked this pull request as ready for review November 18, 2022 13:36
@vkarak vkarak changed the title [bugfix] Expand nodelist with the scontrol utility [bugfix] Expand the Slurm nodelist using scontrol and not the builtin nodelist_expand() function Nov 18, 2022
@vkarak vkarak merged commit 93de6f4 into reframe-hpc:master Nov 18, 2022
@ekouts ekouts deleted the bugfix_expand_nodelist branch March 13, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reframe crashes when expanding a node list

3 participants