Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jun 15, 2023

Closes #2906.

@vkarak vkarak added this to the ReFrame 4.3 milestone Jun 15, 2023
@vkarak vkarak requested review from ekouts, teojgo and victorusu June 15, 2023 14:55
@vkarak vkarak self-assigned this Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1d9a526) 86.96% compared to head (04b33d8) 86.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2928   +/-   ##
=======================================
  Coverage   86.96%   86.96%           
=======================================
  Files          60       60           
  Lines       11551    11557    +6     
=======================================
+ Hits        10045    10051    +6     
  Misses       1506     1506           
Impacted Files Coverage Δ
reframe/core/pipeline.py 93.92% <100.00%> (+0.03%) ⬆️
reframe/core/schedulers/__init__.py 98.40% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

vkarak added 2 commits June 16, 2023 11:38
If the code is buggy an `UnboundLocalError` will be thrown during the
job creation
@vkarak vkarak merged commit e8efe9b into reframe-hpc:master Jun 16, 2023
@vkarak vkarak deleted the bugfix/job-test-name branch June 16, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants