Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Oct 16, 2023

Closes #3015.

@vkarak vkarak added this to the ReFrame 4.5 milestone Oct 16, 2023
@vkarak vkarak requested review from teojgo and victorusu October 16, 2023 21:52
@vkarak vkarak self-assigned this Oct 16, 2023
@vkarak vkarak linked an issue Oct 16, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (19d9782) 86.70% compared to head (314ef82) 86.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3017   +/-   ##
=======================================
  Coverage   86.70%   86.70%           
=======================================
  Files          61       61           
  Lines       11996    11996           
=======================================
  Hits        10401    10401           
  Misses       1595     1595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The them in the sentences doesn't feel right to me. But I am not a native speaker.

@vkarak vkarak requested a review from victorusu October 18, 2023 07:04
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@victorusu victorusu merged commit 113e62e into reframe-hpc:master Oct 19, 2023
@vkarak vkarak deleted the doc/update-readme branch October 19, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update README w.r.t. to site test repos

2 participants