Print filename if a test file contains syntax errors #308
Conversation
* Raise a `ReframeSyntaxError` with a descriptive message if parsing of a `RegressionTest` fails. * Create the corresponding unittest.
reframe/frontend/loader.py
Outdated
| except SyntaxError as e: | ||
| message = ('\nRegression check syntax error:\n{0}Line: {1}\n' | ||
| 'File: {2}'.format(e.text, e.lineno, filename)) | ||
| raise ReframeSyntaxError(message) |
There was a problem hiding this comment.
I don't like very much reraising a real SyntaxError as ReframeSyntaxError. The purpose of the latter is just to denote errors in the usage of the decorators. I agree the name is not very accurate, but I couldn't come up with a better name.
The problem here is firstly conceptual: ReframeSyntaxErrors are ReframeErrors, but a real SyntaxError can never be a ReframeError. Secondly, reraising it differently may hide useful information from real problems.
The solution to this problem is really simple! Just pass a filename argument to parse(). Have a look here.
unittests/test_loader.py
Outdated
| def test_load_invalid_sytax(self): | ||
| self.assertRaises(ReframeSyntaxError, self.loader.load_from_file, | ||
| 'unittests/resources/checks_unlisted/' | ||
| 'invalid_syntax_check.py') |
There was a problem hiding this comment.
Here you should check that the filename attribute of the raised SyntaxError is set properly.
vkarak
changed the title
reframe/frontend/loader.py
Outdated
| import reframe.utility as util | ||
| from reframe.core.exceptions import NameConflictError, RegressionTestLoadError | ||
| from reframe.core.exceptions import (NameConflictError, | ||
| RegressionTestLoadError) |
| with self.assertRaises(SyntaxError) as e: | ||
| self.loader.load_from_file(invalid_check) | ||
|
|
||
| self.assertEqual(e.exception.filename, invalid_check) |
There was a problem hiding this comment.
I know that e is visible outside the with statement, but does it make sense to have this assertion outside the with block?
There was a problem hiding this comment.
If you put the assertion inside the with block, it is not reachable since the with block exits once the exception is thrown.
|
@jenkins-cscs retry dom |
Raise a
ReframeSyntaxErrorwith a descriptive message if parsing ofa
RegressionTestfails.Create the corresponding unittest
Fixes #267