Skip to content

Print filename if a test file contains syntax errors #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2018
Merged

Print filename if a test file contains syntax errors #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01a0fc1
Raise ReframeSyntaxError if check parsing fails
May 29, 2018
b9231b2
Address PR comments
May 31, 2018
c449faf
Address PR comments (version 2)
Jun 1, 2018
201c9a7
Merge branch 'master' into bugfix/syntax_error_filename
vkarak Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reframe/frontend/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _validate_source(self, filename):
further tests and finalizes and validation."""

with open(filename, 'r') as f:
source_tree = ast.parse(f.read())
source_tree = ast.parse(f.read(), filename)

validator = RegressionCheckValidator()
validator.visit(source_tree)
Expand Down
6 changes: 6 additions & 0 deletions unittests/resources/checks_unlisted/invalid_syntax_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import reframe as rfm


@rfm.simple_test
class InvalidSyntaxTest(rfm.RegressionTest:
pass
8 changes: 8 additions & 0 deletions unittests/test_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,11 @@ def test_conflicted_checks(self):
def test_load_error(self):
self.assertRaises(OSError, self.loader.load_from_file,
'unittests/resources/checks/foo.py')

def test_load_invalid_sytax(self):
invalid_check = ('unittests/resources/checks_unlisted/'
'invalid_syntax_check.py')
with self.assertRaises(SyntaxError) as e:
self.loader.load_from_file(invalid_check)

self.assertEqual(e.exception.filename, invalid_check)
Copy link
Contributor

@vkarak vkarak May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that e is visible outside the with statement, but does it make sense to have this assertion outside the with block?

Copy link
Contributor Author

@teojgo teojgo Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put the assertion inside the with block, it is not reachable since the with block exits once the exception is thrown.