Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Sep 6, 2018

Closes #327
Closes #390

@codecov-io
Copy link

codecov-io commented Sep 6, 2018

Codecov Report

Merging #442 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.03%     
==========================================
  Files          70       70              
  Lines        8611     8611              
==========================================
- Hits         7858     7856       -2     
- Misses        753      755       +2
Impacted Files Coverage Δ
reframe/core/config.py 82.72% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e26e8c...5f2ee48. Read the comment docs.

@vkarak vkarak requested a review from victorusu September 6, 2018 07:41
@vkarak vkarak changed the title Update OSU microbenchmark test to new syntax and build system [test] Update OSU microbenchmark test to new syntax and build system Sep 6, 2018
def __init__(self, **kwargs):
super().__init__('gpu_bandwidth', **kwargs)
@rfm.simple_test
class Pt2PtCUDABandwidthTest(Pt2PtBaseTest):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the corresponding latency one are actually G2G tests using CUDA. Name them accordingly, e.g., G2GBandwidthTest.

@rsarm
Copy link
Contributor Author

rsarm commented Sep 10, 2018

To pass the tags on the parameterized test AlltoAllTest, should it be better something like self.tags = set(tags if isinstance(tags, list) else [tags]) to allow passing both ['production'] and [['production']]?

os.path.dirname(__file__), **kwargs)
@rfm.parameterized_test([['production']])
class AlltoallTest(rfm.RegressionTest):
def __init__(self, tags):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean it like that. The tests should take a single string argument of whether it is production or not. Then you set the tags as usual:

@rfm.parameterized_test(['production'])
class AlltoallTest(rfm.RegressionTest):
    def __init__(self, variant):
        self.tags = {variant}

$(CC) $(CPPFLAGS) -o $(@) -c $(@:.o=.c)

p2p_osu_bw: $(OBJS_BW)
$(CC) $(CPPFLAGS) $(LDFLAGS) $(OBJS_BW) -o $(@)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should still pass the CXXFLAGS if you want to be completely correct. CPPFLAGS are the preprocessor flags, i.e., the -D and -I options mostly.



@rfm.simple_test
class GPGLatencyTest(P2PBaseTest):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPG -> G2G.

@vkarak
Copy link
Contributor

vkarak commented Sep 12, 2018

@jenkins-cscs retry dom kesch

@vkarak
Copy link
Contributor

vkarak commented Sep 12, 2018

@jenkins-cscs retry dom

@vkarak vkarak merged commit 24ec300 into reframe-hpc:master Sep 12, 2018
@rsarm rsarm deleted the checks/g2g branch November 26, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants