-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Update OSU microbenchmark test to new syntax and build system #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.03%
==========================================
Files 70 70
Lines 8611 8611
==========================================
- Hits 7858 7856 -2
- Misses 753 755 +2
Continue to review full report at Codecov.
|
| def __init__(self, **kwargs): | ||
| super().__init__('gpu_bandwidth', **kwargs) | ||
| @rfm.simple_test | ||
| class Pt2PtCUDABandwidthTest(Pt2PtBaseTest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the corresponding latency one are actually G2G tests using CUDA. Name them accordingly, e.g., G2GBandwidthTest.
|
To pass the tags on the parameterized test |
| os.path.dirname(__file__), **kwargs) | ||
| @rfm.parameterized_test([['production']]) | ||
| class AlltoallTest(rfm.RegressionTest): | ||
| def __init__(self, tags): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean it like that. The tests should take a single string argument of whether it is production or not. Then you set the tags as usual:
@rfm.parameterized_test(['production'])
class AlltoallTest(rfm.RegressionTest):
def __init__(self, variant):
self.tags = {variant}| $(CC) $(CPPFLAGS) -o $(@) -c $(@:.o=.c) | ||
|
|
||
| p2p_osu_bw: $(OBJS_BW) | ||
| $(CC) $(CPPFLAGS) $(LDFLAGS) $(OBJS_BW) -o $(@) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should still pass the CXXFLAGS if you want to be completely correct. CPPFLAGS are the preprocessor flags, i.e., the -D and -I options mostly.
|
|
||
|
|
||
| @rfm.simple_test | ||
| class GPGLatencyTest(P2PBaseTest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPG -> G2G.
|
@jenkins-cscs retry dom kesch |
|
@jenkins-cscs retry dom |
Closes #327
Closes #390