Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Nov 9, 2018

@rsarm rsarm added this to the https://github.com/eth-cscs/reframe-tests/milestone/9 milestone Nov 9, 2018
@rsarm rsarm self-assigned this Nov 9, 2018
@rsarm rsarm requested a review from vkarak November 9, 2018 09:37
@teojgo teojgo modified the milestones: https://github.com/eth-cscs/reframe-tests/milestone/9, ReFrame sprint 2018w44 Nov 9, 2018
@rsarm
Copy link
Contributor Author

rsarm commented Nov 9, 2018

@jenkins-cscs retry all

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be merged. There are three issues related to NAMD, that I'd say should be addressed by a single PR. This PR must incorporate the change of #549 and invalidate that PR, and it must also address issue https://github.com/eth-cscs/reframe-tests/issues/33. I have also comments about the test itself, but I'll come back to them later.

@vkarak vkarak mentioned this pull request Nov 13, 2018
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test must be further refactored. Currently, they are a mixture of old and new syntax. This is how it should be done:

class NamdBaseCheck(rfm.RunOnlyRegressionTest):
    def __init__(self, version, variant):
        super().__init__()
        self.name = 'namd_%s_%s_check' % (version, variant)
        self.descr = 'NAMD check (%s, %s) % (version, variant)
        ...

@rfm.parameterized_test(['maint'], ['prod'])
class NamdGPUCheck(NamdBaseCheck):
    def __init__(self, variant):
        super().__init__('gpu', variant)
        ...

@rfm.parameterized_test(['maint'], ['prod'])
class NamdCPUCheck(NamdBaseCheck):
    def __init__(self, variant):
        super().__init__('cpu', variant)
        ...

You could also do everything in a single class that you instantiate four times. This is up to you.

@rsarm
Copy link
Contributor Author

rsarm commented Nov 16, 2018

@jenkins-cscs retry daint

@vkarak vkarak merged commit 3e66bbb into reframe-hpc:master Nov 17, 2018
@rsarm rsarm deleted the checks/namd-perf branch November 26, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants