-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Improve handling of bad tests to avoid frontend crashing #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Improve handling of bad tests to avoid frontend crashing #623
Conversation
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should give the option to print the stack traces on demand. When developing a test, this is really useful. We have an issue #491 about that. But the problem with the proposed implementation is that it will not be easy to print the stack trace, unless we make the program options globally available, which is not the best solution perhaps. I am not yet convinced that what we are trying here is best solution.
|
Hello @rsarm, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated on January 24, 2019 at 23:28 Hours UTC |
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I have cleaned up slightly the implementation, but it is essentially the same. The stack trace is emitted at the verbose level and user is hinted to use the |
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
==========================================
+ Coverage 91.75% 91.82% +0.07%
==========================================
Files 76 77 +1
Lines 9326 9346 +20
==========================================
+ Hits 8557 8582 +25
+ Misses 769 764 -5
Continue to review full report at Codecov.
|
|
I mark this as a WIP, because we still need an additional unit test to cover the case of the loading of a bad test. |
0234f4d to
dd5e36a
Compare
dd5e36a to
fcb30fc
Compare
Closes #554