[refactor] Refactor PrettyPrinter and enable colors in the general logger
#654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `PrettyPrinter` is now a proxy to the ReFrame's logger and takes particular care in formatting specially the progress output. It also prefixes errors and warnings with the program name. - The general framework logger is now also capable of colorizing its output. This allows errors and warnings to be colorized when logged from anywhere in the framework.
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=========================================
+ Coverage 91.68% 91.7% +0.02%
=========================================
Files 74 74
Lines 9256 9263 +7
=========================================
+ Hits 8486 8495 +9
+ Misses 770 768 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 91.68% 91.73% +0.05%
==========================================
Files 74 76 +2
Lines 9256 9302 +46
==========================================
+ Hits 8486 8533 +47
+ Misses 770 769 -1
Continue to review full report at Codecov.
|
vkarak
changed the title
PrettyPrinter and enable colors in the general loggerPrettyPrinter and enable colors in the general logger
vkarak
changed the title
PrettyPrinter and enable colors in the general loggerPrettyPrinter and enable colors in the general logger
vkarak
force-pushed
the
refactor/colorize-logger
branch
from
9a86deb to
adf1e00
Compare
vkarak
changed the title
PrettyPrinter and enable colors in the general loggerPrettyPrinter and enable colors in the general logger
Contributor
Contributor
Author
|
@victorusu Yeah, sure! I wanted to do that yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrettyPrinteris now a proxy to the ReFrame's logger and takes particular care in formatting specially the progress output.This is useful for #623.