[bugfix] Fix Slurm backend failures when trying node lists with inexistent nodes #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@kraushm Why this is a WIP? |
kraushm
changed the title
kraushm
changed the title
|
Hello @kraushm, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2019-03-14 15:01:56 UTC |
kraushm
force-pushed
the
bugfix/improper-scontrol-output-handling
branch
from
4e217f5 to
041941a
Compare
kraushm
changed the title
Contributor
Author
|
@jenkins-cscs retry kesch |
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 91.82% 91.79% -0.03%
==========================================
Files 77 77
Lines 9488 9491 +3
==========================================
Hits 8712 8712
- Misses 776 779 +3
Continue to review full report at Codecov.
|
teojgo
requested changes
Mar 13, 2019
teojgo
approved these changes
Mar 13, 2019
teojgo
approved these changes
Mar 13, 2019
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
lgtm. Tested both with valid and invalid node names and works fine.
Contributor
Author
|
@jenkins-cscs retry daint |
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the way the set of available nodes is built in SLURM, in order to prevent erroneous entries (e. g. "not found")
Fixes #694