Skip to content

[bugfix] Fix Slurm backend failures when trying node lists with inexistent nodes #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2019
Merged

[bugfix] Fix Slurm backend failures when trying node lists with inexistent nodes #713

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
041941a
Add search to scontrol output for nodes not found
kraushm Mar 12, 2019
dc8901a
Correct (_)run_command
kraushm Mar 12, 2019
54229da
Add os_ext to run_command
kraushm Mar 12, 2019
7187456
refactor code
kraushm Mar 13, 2019
8e7fb55
Merge branch 'master' into bugfix/improper-scontrol-output-handling
vkarak Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions reframe/core/schedulers/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,14 +240,17 @@ def _get_reservation_nodes(self, reservation):
return {SlurmNode(descr) for descr in node_descriptions}

def _get_nodes_by_name(self, nodespec):
try:
completed = _run_strict('scontrol -a show -o node %s' % nodespec)
except SpawnedProcessError as e:
raise JobError('could not retrieve the node description '
'of nodes: %s' % nodespec) from e

completed = os_ext.run_command('scontrol -a show -o node %s' %
nodespec)
node_descriptions = completed.stdout.splitlines()
return {SlurmNode(descr) for descr in node_descriptions}
nodes_avail = set()
for descr in node_descriptions:
try:
nodes_avail.add(SlurmNode(descr))
except JobError:
pass

return nodes_avail

def _set_nodelist(self, nodespec):
if self._nodelist is not None:
Expand Down