[test] Add Intel Advisor Roofline test #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jgphpc, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2019-03-29 09:07:46 UTC |
victorusu
previously requested changes
Mar 27, 2019
Contributor
victorusu
left a comment
victorusu
left a comment
There was a problem hiding this comment.
I think we cannot publish this test/files.
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 77 77
Lines 9504 9504
=======================================
Hits 8722 8722
Misses 782 782Continue to review full report at Codecov.
|
vkarak
requested changes
Mar 28, 2019
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
vkarak
requested changes
Mar 29, 2019
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Almost there. I have a minor comment only.
cscs-checks/tools/profiling_and_debugging/intel_advisor_roofline.py
Outdated
Show resolved
Hide resolved
teojgo
requested changes
Mar 29, 2019
teojgo
approved these changes
Mar 29, 2019
vkarak
approved these changes
Mar 29, 2019
Contributor
Author
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.cscs.ch/browse/UES-214