Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Apr 7, 2019

  • This fixes the problem with the duplicate module commands. Essentially, we revert back to the original solution of deep-copying the environments and the partitions. Environments are not immutable, since they hold a state. Similarly, since a partition holds a reference to its local environment, it's not immutable as well.
  • This PR removes also the stale Sandbox class.

Fixes #737.

- This fixes the problem with the duplicate module commands
- This commit removes also the stale `Sandbox` class.
@vkarak vkarak added this to the ReFrame sprint 2019w13 milestone Apr 7, 2019
@vkarak vkarak self-assigned this Apr 7, 2019
@vkarak vkarak requested a review from teojgo April 7, 2019 20:33
@vkarak vkarak changed the title [bugfix] Fix duplicate module commands emitted while executing test cases [WIP] [bugfix] Fix duplicate module commands emitted while executing test cases Apr 7, 2019
- Partitions contain reference to their local environment, eventually
  making them mutable as well.
@vkarak vkarak changed the title [WIP] [bugfix] Fix duplicate module commands emitted while executing test cases [bugfix] Fix duplicate module commands emitted while executing test cases Apr 7, 2019
@codecov-io
Copy link

codecov-io commented Apr 7, 2019

Codecov Report

Merging #740 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   91.73%   91.74%   +<.01%     
==========================================
  Files          77       76       -1     
  Lines        9527     9509      -18     
==========================================
- Hits         8740     8724      -16     
+ Misses        787      785       -2
Impacted Files Coverage Δ
unittests/test_fields.py 97.22% <ø> (-0.2%) ⬇️
reframe/frontend/executors/__init__.py 97.19% <100%> (-0.03%) ⬇️
reframe/core/config.py 84.48% <0%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3724185...bb978f6. Read the comment docs.

@vkarak
Copy link
Contributor Author

vkarak commented Apr 9, 2019

@jenkins-cscs retry daint kesch

@vkarak vkarak merged commit d36ac09 into reframe-hpc:master Apr 9, 2019
@vkarak vkarak deleted the bugfix/duplicate-module-loads branch April 9, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reframe emits duplicated module load commands

3 participants