[feat] Print performance variable name in case of performance errors #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow `assert_reference` to accept a `tag` parameter. * Use the performance tag in `assert_reference` at the `check_performance` stage.
vkarak
requested changes
May 21, 2019
added 2 commits
May 24, 2019 11:37
vkarak
requested changes
May 26, 2019
- Message in case of performance failures is set by check_performance() including also the name of the performance variable that failed.
vkarak
approved these changes
May 26, 2019
vkarak
changed the title
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 91.51% 91.51% -0.01%
==========================================
Files 76 78 +2
Lines 9550 9791 +241
==========================================
+ Hits 8740 8960 +220
- Misses 810 831 +21
Continue to review full report at Codecov.
|
Contributor
Author
|
@vkarak lgtm |
Contributor
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
assert_referenceto accept atagparameter.Use the performance tag in
assert_referenceat thecheck_performancestage.Fixes #753