Skip to content

[feat] Print performance variable name in case of performance errors #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2019
Merged

[feat] Print performance variable name in case of performance errors #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
120eaa4
Print the tag of the performance in failure message
May 20, 2019
84987c0
Address PR comments
May 24, 2019
34a67ec
Fix the assignment of message
May 24, 2019
f67c8a7
Correct behaviour of msg arg. in assert_reference
May 26, 2019
14fbeb0
Merge branch 'master' into feature/message_perf_vars
May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions reframe/core/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,14 +1134,20 @@ def check_performance(self):
"tag `%s' not resolved in references for `%s'" %
(tag, self._current_partition.fullname))

self._perfvalues[key] = (value, *self.reference[key])
self._perfvalues[key] = (tag, value, *self.reference[key])
self._perf_logger.log_performance(logging.INFO, tag, value,
*self.reference[key])

for val, *reference in self._perfvalues.values():
ref, low_thres, high_thres, *_ = reference
for values in self._perfvalues.values():
tag, val, ref, low_thres, high_thres, *_ = values
try:
evaluate(assert_reference(val, ref, low_thres, high_thres))
evaluate(
assert_reference(
val, ref, low_thres, high_thres,
msg=('failed to meet reference: %s={0}, '
'expected {1} (l={2}, u={3})' % tag),
)
)
except SanityError as e:
raise PerformanceError(e)

Expand Down
2 changes: 1 addition & 1 deletion reframe/utility/sanity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ def calc_bound(thres):
try:
evaluate(assert_bounded(val, lower, upper))
except SanityError:
error_msg = '{0} is beyond reference value {1} (l={2}, u={3})'
error_msg = msg or '{0} is beyond reference value {1} (l={2}, u={3})'
raise SanityError(_format(error_msg, val, ref, lower, upper))
else:
return True
Expand Down