[bugfix] Fix bug in performance report output #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
reviewed
Jun 5, 2019
reframe/frontend/statistics.py
Outdated
| for key, ref in t.check.perfvalues.items(): | ||
| var = key.split(':')[-1] | ||
| val = ref[0] | ||
| val = ref[1] |
Contributor
There was a problem hiding this comment.
I am wondering what has changed in the reference tuple?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
This change in pipeline.py is redundant. I suggest reverting it back without the tag. Then statistics will be fine again.
vkarak
requested changes
Jun 5, 2019
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I think we should add a basic unit test that will protect us from future regressions.
vkarak
requested changes
Jun 5, 2019
reframe/frontend/statistics.py
Outdated
| for key, ref in t.check.perfvalues.items(): | ||
| var = key.split(':')[-1] | ||
| val = ref[0] | ||
| val = ref[1] |
Contributor
There was a problem hiding this comment.
This change in pipeline.py is redundant. I suggest reverting it back without the tag. Then statistics will be fine again.
Contributor
|
I am raising this issue's priority, cos this feature was supposed to be introduced in 2.18 and it is broken! |
vkarak
approved these changes
Jun 6, 2019
Contributor
|
@jenkins-cscs retry daint |
Contributor
|
@jenkins-cscs retry none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #816