Skip to content

[bugfix] Fix bug in performance report output #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2019
Merged

[bugfix] Fix bug in performance report output #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c778314
Fix bug in performance report output
Jun 5, 2019
0a30a02
Address PR comments
Jun 5, 2019
e16d870
Address PR comments (version 2)
Jun 6, 2019
275ebd9
Minor style fixes
Jun 6, 2019
db096a4
Merge branch 'master' into bugfix/performance_report_numbers
Jun 7, 2019
4fed175
Merge branch 'master' into bugfix/performance_report_numbers
Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions reframe/core/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,19 +1134,19 @@ def check_performance(self):
"tag `%s' not resolved in references for `%s'" %
(tag, self._current_partition.fullname))

self._perfvalues[key] = (tag, value, *self.reference[key])
self._perfvalues[key] = (value, *self.reference[key])
self._perf_logger.log_performance(logging.INFO, tag, value,
*self.reference[key])

for values in self._perfvalues.values():
tag, val, ref, low_thres, high_thres, *_ = values
for key, values in self._perfvalues.items():
val, ref, low_thres, high_thres, *_ = values
tag = key.split(':')[-1]
try:
evaluate(
assert_reference(
val, ref, low_thres, high_thres,
msg=('failed to meet reference: %s={0}, '
'expected {1} (l={2}, u={3})' % tag),
)
'expected {1} (l={2}, u={3})' % tag))
)
except SanityError as e:
raise PerformanceError(e)
Expand Down
9 changes: 9 additions & 0 deletions unittests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,15 @@ def test_performance_check_failure(self):
['login'], self.environs))
self.assertTrue(self._perflog_exists('PerformanceFailureCheck'))

def test_performance_report(self):
self.checkpath = ['unittests/resources/checks/frontend_checks.py']
self.more_options = ['-t', 'PerformanceFailureCheck',
'--performance-report']
returncode, stdout, stderr = self._run_reframe()

self.assertIn(r'PERFORMANCE REPORT', stdout)
self.assertIn(r'perf: 10 Gflop/s', stdout)

def test_skip_system_check_option(self):
self.checkpath = ['unittests/resources/checks/frontend_checks.py']
self.more_options = ['--skip-system-check', '-t', 'NoSystemCheck']
Expand Down