Skip to content

[bugfix] Make Slurm WLM backends aware of job arrays #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 4, 2019
Merged

[bugfix] Make Slurm WLM backends aware of job arrays #840

merged 9 commits into from
Jul 4, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jun 24, 2019

Fixes #839

@teojgo teojgo requested a review from vkarak June 24, 2019 09:05
@teojgo teojgo self-assigned this Jun 24, 2019
@teojgo teojgo mentioned this pull request Jun 24, 2019
Closed
@teojgo
Copy link
Contributor Author

teojgo commented Jun 24, 2019

@jenkins-cscs retry daint dom

@vkarak vkarak changed the title [bugfix] Make Slurm/Squeue schedulers aware of job arrays [bugfix] Make Slurm WLM backends aware of job arrays Jun 25, 2019
vkarak
vkarak requested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need a unit test for this.

@vkarak vkarak added this to the ReFrame sprint 2019w23 milestone Jun 27, 2019
Use separate files for job array output/error
164963b 
* Create function to concatenate file contents.

* In case of job arrays create separate output/error
  files and concatenate after the job finishes.
vkarak
vkarak requested changes Jul 2, 2019
View reviewed changes
vkarak
vkarak requested changes Jul 3, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

Merging #840 into master will decrease coverage by 0.15%.
The diff coverage is 55.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
- Coverage   91.84%   91.69%   -0.16%     
==========================================
  Files          80       80              
  Lines       10215    10279      +64     
==========================================
+ Hits         9382     9425      +43     
- Misses        833      854      +21
Impacted Files Coverage Δ
unittests/test_utility.py 99.2% <100%> (+0.01%) ⬆️
reframe/core/schedulers/slurm.py 55.33% <34.09%> (-0.6%) ⬇️
unittests/test_schedulers.py 96.85% <50%> (-0.8%) ⬇️
reframe/utility/os_ext.py 89.69% <81.81%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4fb6c...ffaccdc. Read the comment docs.

@vkarak vkarak merged commit 4291cc7 into reframe-hpc:master Jul 4, 2019
@teojgo teojgo deleted the bugfix/slurm_job_arrays_aware branch July 4, 2019 08:49
@teojgo teojgo mentioned this pull request Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@teojgo teojgo

Labels

bugfix prio: important

Projects

None yet

Milestone

ReFrame sprint 2019w23

Development

Successfully merging this pull request may close these issues.

ReFrame fails to detect job status of Slurm job arrays

3 participants

@teojgo @codecov-io @vkarak