Skip to content

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Oct 8, 2019

@jgphpc jgphpc self-assigned this Oct 8, 2019
@pep8speaks
Copy link

pep8speaks commented Oct 8, 2019

Hello @jgphpc, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-10-21 08:41:38 UTC

@vkarak vkarak changed the title [test] internal PE testing [wip] [test] internal PE testing Oct 8, 2019
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #960 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #960   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          80       80           
  Lines       10575    10575           
=======================================
  Hits         9695     9695           
  Misses        880      880

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9832a6b...6849036. Read the comment docs.

@jgphpc jgphpc changed the title [wip] [test] internal PE testing [test] internal PE testing Oct 15, 2019
@jgphpc jgphpc added this to the ReFrame Sprint 2019w41 milestone Oct 15, 2019
@jgphpc jgphpc requested review from teojgo and vkarak October 15, 2019 17:56
@jgphpc
Copy link
Contributor Author

jgphpc commented Oct 15, 2019

1 comment: #966 (comment)

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather use a settings file derived from the generic settings: reframe/settings.py.

@vkarak vkarak changed the title [test] internal PE testing [ci] internal PE testing Oct 17, 2019
@vkarak vkarak changed the title [ci] internal PE testing [ci] Config file for additional system Oct 21, 2019
@vkarak vkarak changed the title [ci] Config file for additional system [ci] Add config file for additional system Oct 21, 2019
@vkarak vkarak merged commit 0266973 into reframe-hpc:master Oct 21, 2019
@jgphpc jgphpc deleted the tiger branch October 23, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants