Skip to content

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Oct 11, 2019

Will fix UES-580

Changes needed to run on tiger, is there a better way to do it ?

@jgphpc jgphpc requested review from ajocksch and vkarak October 11, 2019 11:03
@jgphpc jgphpc self-assigned this Oct 11, 2019
@jgphpc jgphpc changed the title [test] [test] port gpudirect check to tiger Oct 11, 2019
@vkarak vkarak added this to the ReFrame Sprint 2019w41 milestone Oct 11, 2019
@vkarak vkarak changed the title [test] port gpudirect check to tiger [test] Port gpudirect check to tiger Oct 15, 2019
@vkarak vkarak changed the title [test] Port gpudirect check to tiger [test] Port GPUDirect check to Tiger Oct 15, 2019
@vkarak
Copy link
Contributor

vkarak commented Oct 15, 2019

@jgphpc To answer your question "is there a better way to do it ?"

I don't think you can do it differently for the moment, but in the future we can think of attaching attributes to systems, that we can later check in the tests. That would decouple the test further.

@vkarak vkarak merged commit 762b05e into reframe-hpc:master Oct 15, 2019
@jgphpc
Copy link
Contributor Author

jgphpc commented Oct 15, 2019

#966 (comment)

Would it be possible to detect that we are on a Cray system (/opt/cray/ or /etc/opt/cray/release exist) then we could use stg like:
if self.current_system.name in {'dom', 'daint', CRAY}:
instead of
if self.current_system.name in {'dom', 'daint', 'tiger'}:
?

or stg like: reframe --skip-system-check --cray-system

@jgphpc jgphpc deleted the UES-580_gdr branch October 15, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants