Skip to content

fix: remove phantom git submodule reference at path "reframe" - #1765

Merged
magic-peach merged 1 commit into
mainfrom
fix/remove-phantom-submodule
Sep 2, 2026
Merged

fix: remove phantom git submodule reference at path "reframe"#1765
magic-peach merged 1 commit into
mainfrom
fix/remove-phantom-submodule

Conversation

@magic-peach

Copy link
Copy Markdown
Collaborator

Summary

  • Removes a stray gitlink (mode 160000) at the repo root path reframe, pointing to commit 9022ede4215ab686a829b4bd88a25cf67bdeb248 with no corresponding .gitmodules entry.
  • This just broke a Netlify deploy: Error checking out submodules: fatal: No url found for submodule path 'reframe' in .gitmodules. The identical error also appears in a Chromatic Actions run's post-job git cleanup from a few days ago — previously unexplained, now accounted for. Any tool that clones with submodule init enabled hits this.
  • Also picks up two .gitignore entries (.env*, .netlify) added locally by the Netlify/Vercel CLI setup, unrelated but already sitting in the working tree.

Test plan

  • git ls-tree origin/main no longer shows a 160000 entry after this merges
  • Retry the failed Netlify deploy for reframe-os once this is on main

🤖 Generated with Claude Code

https://claude.ai/code/session_01L5gqyU5QKQtLAza6hL6dXv

The repo root has had a stray gitlink (mode 160000) at path "reframe"
pointing to commit 9022ede, with no
corresponding .gitmodules entry to give it a URL. Any tool that clones
with submodule init fails on it: this just broke a Netlify deploy
("Error checking out submodules: fatal: No url found for submodule path
'reframe' in .gitmodules") and is the same error seen in a Chromatic
Actions run's post-job cleanup a few days ago, previously undiagnosed.

Also picks up .gitignore entries (.env*, .netlify) added locally by the
Netlify/Vercel CLI setup earlier.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L5gqyU5QKQtLAza6hL6dXv
@netlify

netlify Bot commented Sep 2, 2026

Copy link
Copy Markdown

Deploy Preview for reframe-os ready!

Name Link
🔨 Latest commit f48376a
🔍 Latest deploy log https://app.netlify.com/projects/reframe-os/deploys/6a980bd47532160008c4868b
😎 Deploy Preview https://deploy-preview-1765--reframe-os.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:refactor Code refactor type:testing Testing labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @magic-peach!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @magic-peach

Please fix the following before your PR can be reviewed:

  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@magic-peach
magic-peach merged commit f9c5d7f into main Sep 2, 2026
16 of 19 checks passed
magic-peach added a commit that referenced this pull request Sep 2, 2026
main picked up the org rename (#1756) and the phantom-submodule fix
(#1765) since this branch was created; both landed cleanly. bun.lock had
a real conflict (main gained Snyk's dependency, this branch gained the
Datadog RUM packages) — resolved by regenerating the lockfile via
`bun install` against the merged package.json rather than hand-editing
conflict markers. tsc --noEmit, lint, and build all verified clean
post-merge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L5gqyU5QKQtLAza6hL6dXv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix type:refactor Code refactor type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant