Skip to content

fix(release): use exact promotion artifact path - #742

Merged
jeremi merged 1 commit into
mainfrom
fix/release-promotion-artifact-path
Aug 12, 2026
Merged

fix(release): use exact promotion artifact path#742
jeremi merged 1 commit into
mainfrom
fix/release-promotion-artifact-path

Conversation

@jeremi

@jeremi jeremi commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

  • download the one exact promotion artifact by name into the path consumed by image promotion
  • use the same explicit download contract in finalization
  • add regression coverage for artifact identity, extraction path, and both manifest consumers

Recovery state

Publication run 31636799560 created the exact bound v0.21.0 draft, then failed before registry login because the pattern download extracted directly into inputs/ while the next steps looked under a synthetic artifact-name subdirectory. All final OCI tags remain absent. The v0.21.0 tag, candidate run 31632402859/1, candidate manifest, and staged draft assets remain unchanged.

Verification

  • python3 -m unittest discover -s release/scripts -p 'test_*.py' (294 passed)\n- python3 -m unittest release/scripts/test_release_workflow_structure.py release/scripts/test_release_workflow_guard.py (44 passed)\n- python3 release/scripts/check-gates-inventory.py\n- python3 -m unittest release/scripts/test_check_gates_inventory.py (47 passed)\n- workflow YAML parse\n- git diff --check

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@jeremi
jeremi merged commit 3a52ab0 into main Aug 12, 2026
30 checks passed
@jeremi
jeremi deleted the fix/release-promotion-artifact-path branch August 12, 2026 20:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28d2c25e31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

with:
pattern: release-*-input-${{ github.run_id }}
path: inputs
name: release-promotion-input-${{ github.run_id }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The reviewed commit has no Signed-off-by: trailer, so it cannot be accepted under the repository's mandatory DCO policy; recreate or re-sign the commit with the author's DCO sign-off before merging.

AGENTS.md reference: AGENTS.md:L274-L274

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant