fix: properly extract tags that include forward slashes#5928
Merged
beckermr merged 1 commit intoregro:mainfrom Apr 21, 2026
Merged
fix: properly extract tags that include forward slashes#5928beckermr merged 1 commit intoregro:mainfrom
beckermr merged 1 commit intoregro:mainfrom
Conversation
beckermr
requested changes
Apr 21, 2026
Contributor
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please add a test!
salim-b
added a commit
to salim-b/dart-sass-feedstock
that referenced
this pull request
Apr 21, 2026
By default, all sources are enabled and the `github` update source currently has a bug when tags contain forward slashes, cf. regro/cf-scripts#5928. This change works around this problem by only checking GitHub's `/releases/latest` API endpoint which is automatically limited to the primary latest release, ignoring side-packages like `sass_api`.
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5928 +/- ##
==========================================
+ Coverage 80.62% 80.69% +0.07%
==========================================
Files 146 146
Lines 17434 17442 +8
==========================================
+ Hits 14056 14075 +19
+ Misses 3378 3367 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Done :) |
Fixes extracting tags from the `github` source (atom feed with URLs of the form `https://github.com/<owner>/<repo>/releases/tag/<tag>`). Before, when a tag contained a slash like e.g. `sass_api/17.5.0`, everything up to and including the last slash was stripped prematurely, wrongly passing `17.5.0` instead of the full `sass_api/17.5.0` tag name when evaluating `is_tag_ignored()`. As a consequence, the [`bot.version_updates.allowed_tag_globs`](https://conda-forge.org/docs/maintainer/conda_forge_yml/#bot) config setting wouldn't work as intended.
beckermr
approved these changes
Apr 21, 2026
Contributor
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
The changes and tests look good. This could break existing globs on other feedstocks, but that is a risk we'll have to take I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes extracting tags from the
githubsource (atom feed containing URLs of the formhttps://github.com/<owner>/<repo>/releases/tag/<tag>for all releases of a repository incl. side-packages).Before, when a tag contained a forward slash like e.g.
sass_api/17.5.0, everything up to and including the last slash was stripped, wrongly extracting17.5.0as the tag instead of the fullsass_api/17.5.0tag name. As a consequence, thebot.version_updates.allowed_tag_globsconfig setting wouldn't work as intended.Description:
Checklist:
Cross-refs, links to issues, etc: