skpkg: update to latest scikit-package standards, add Python 3.14 support, remove Python 3.11 support - #1292
skpkg: update to latest scikit-package standards, add Python 3.14 support, remove Python 3.11 support#1292danielsirakov wants to merge 9 commits into
Conversation
…port, remove Python 3.11 support
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
this looks great. I just had a couple of questions
| c_extension: false | ||
| headless: false | ||
| python_version: 3.13 | ||
| python_version: 3.14 |
There was a problem hiding this comment.
I think this maybe needs to be deleted. Was it added by skpkg or manually edited by @danielsirakov ? Please maybe check some other of our diffpy packages.
There was a problem hiding this comment.
I think I manually changed the version number, but I can't remember exactly. Besides the changed version number, the file is exactly how it was before I ran the package update. I checked diffpy.srfit, and it has a tests-on-pr.yml file that looks identical but does not have python_version and run: pip install gooey lines. I'm not 100 percent sure, but I feel like those lines might not have been included in the scikit template. What exactly should I delete? Thank you!
There was a problem hiding this comment.
Yes, please remove the python version number and the pip install gooey lines
There was a problem hiding this comment.
Also remove the pip install gooey logic
There was a problem hiding this comment.
@sbillinge I just checked, and gooey is imported at the top of a lot of the helper files, meaning that I can't remove its logic without breaking the imports, if you're referring to gooey logic in regolith as a whole. There isn't any more gooey logic in the tests-on-pr.yml file. It turns out gooey is actually listed in requirements\pip.txt, so I can still remove this line because it's redundant. I'll remove both lines now and push.
|
@sbillinge just made the quick change to maintainers |
|
@danielsirakov I responded to your questions for hte last couple of changes. |
|
@sbillinge I just removed the python-version and gooey lines from |
|
For some reason the tests are queued and stalled. It may be a good idea to generate a new commit and push it and see if we can trigger the CI |
|
@sbillinge I merged your changes into my local and now the CI passes. Thank you! |
tests are not running in CI. We need to trigger it. That is why I am asking you to generate a new commit and push it to try and unstick it. |
|
@danielsirakov sorry, I forgot to tag you on this. |
|
@sbillinge I see, I thought the merge would get tracked as a new commit. I just pushed an empty commit, does that unstick it? |
|
@danielsirakov now it is not even running the news check. Either we broke the CI scripts with the skpkg update, or some weird thing has happened to GitHub. I recommend that we maybe close the PR and then create a brand new PR. Maybe create a new branch from this branch and push that to origin and make a new PR from that? Also, take a look at changes in the GH Actions scripts and see if we can see anything odd. |
|
I think the github actions issue may be resolved. Please can you try another push? @danielsirakov |
|
@sbillinge Sorry for the delay, I was travelling. I just pushed another empty commit. On my end, it looks like everything is passing, but please let me know if there are any issues again. |
2 participants
I ran scikit package update, updated to add Python 3.14 support, and removed Python 3.11 support.
@sbillinge ready to review
Closes #1271
Closes #1264
Closes #1262
Closes #1246
Closes #1215
Closes #1210
Closes #1208