M1: correctness & safety fixes - #4
Merged
Merged
Conversation
lacraig2
commented
Jun 13, 2026
lacraig2
commented
Collaborator
- Ephemeral-port persistence: display_spec emits the short (preferred) form for any auto local port, so a fallback ephemeral port is no longer frozen as a strict ->PORT on the next launch (+ round-trip test).
- Reap safety: agent records a live client count in its state file; reap_stale_agents only TERMs version-mismatched agents with zero clients, never dropping a live session.
- Tunable attach deadline via PORTMANAGER_ATTACH_DEADLINE_SECS (default 10s).
- Graceful post-fork stderr redirect (no more expect-panic on devnull clone).
- Document the single-client-per-session assumption (supervisor + README).
- Ephemeral-port persistence: display_spec emits the short (preferred) form for any auto local port, so a fallback ephemeral port is no longer frozen as a strict ->PORT on the next launch (+ round-trip test). - Reap safety: agent records a live client count in its state file; reap_stale_agents only TERMs version-mismatched agents with zero clients, never dropping a live session. - Tunable attach deadline via PORTMANAGER_ATTACH_DEADLINE_SECS (default 10s). - Graceful post-fork stderr redirect (no more expect-panic on devnull clone). - Document the single-client-per-session assumption (supervisor + README).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.