Conversation
Member
Author
|
Thanks for the vote of confidence, @matthewcornell . Is the failing check a concern? |
Member
Good catch. Looking back at https://github.com/reichlab/idmodels/actions , I see that the only passing test was the first commit by Evan on Nov 6, 2024 . All others have failed, presumably the same tests (Action history is not kept for a lot of the runs.) So I don't think your change was the culprit. I'll followup up on slack to see if anyone wants to pair on fixing this. |
Member
Author
|
Merging based on comments from @elray1 @matthewcornell @trobacker that suggest this is a known failure and we're just going to 🤞 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10