fix(cli): pin libpff dependencies via the release tarball#443
Merged
Conversation
`build.rs` built libpff from its raw source archive and ran `./synclibs.sh`, which fetches the libyal dependencies (libcerror, libfvalue, ...) from upstream at build time. A recent upstream change broke `libfvalue`, failing every build. Switch to libyal's release tarball, which vendors the dependencies at pinned versions and ships a generated `configure` -- so synclibs.sh / autogen.sh are no longer needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joe-prosser
added a commit
that referenced
this pull request
Jul 9, 2026
… a release tarball (#450) PR #443 switched libpff to libyal's release tarball, which ships a pre-generated `configure`, removing the autoconf/automake requirement. This removes the now-dead autotools scaffolding from the build scripts, CI workflows, and README. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.rsbuilt libpff from its raw source archive and ran./synclibs.sh, which fetches the libyal dependencies (libcerror,libfvalue, …) from upstream at build time. A recent upstream change brokelibfvalue, failing every build.Switch to libyal's release tarball, which vendors the dependencies at pinned versions and ships a generated
configure— sosynclibs.sh/autogen.share no longer needed.