Studio: pattern-set modal — course-repo source, 'Add referenced', commit set to protocol folder (library → colocation)

[mbreiser]

Context

The library-first workflow (now the lead flow in docs/protocol-pattern-workflow.md) saves patterns to the shared patterns/ library, then builds a protocol referencing them by name. That runs fine on any bench (the library is repo-global), but the protocol is not a self-contained pair: Promote-to-shared copies only the colocated <name>_patterns/ folder, and the repo-side pattern checks (W badges on repo-opened protocols) key off colocation.

Today's workaround (documented in the guide): per pattern, in the Pattern Designer — LOAD ▾ → Open from Repo… → 📚 Shared pattern library → open it → ⇪ SAVE TO REPO… → "A protocol's pattern folder". Clunky for N patterns.

Proposal

A one-click "Collect patterns into this protocol's folder…" action in the Arena Studio (File ▾, Edit view, next to Promote):

1. Resolve every pattern: name referenced by the current (saved) protocol.
2. For each name found in patterns/ (and not already in <name>_patterns/): fetch bytes, direct-commit a copy into protocols/<bench-id>/<name>_patterns/.
3. Skip + report names already colocated; list unresolved names loudly (typo or not yet made).
4. Same-name-different-content in the destination → hash-compare guard like Promote (refuse, never overwrite silently).

Building blocks all exist: GH.reqGetContents/runBytes/directCommit (path allowlist already covers both areas), RunnerLib-style pattern-name extraction, the Promote flow's hash guard, and registerRepoPatternPreviews to refresh W badges afterwards.

Notes

• Copying (not moving) is intentional — the library copy stays for other protocols; identical files are free in git (same blob).
• Complements Arena Studio v0.7 Edit-view de-clutter — relocation/cut audit + deferred items #148's deferred item list.

[mbreiser]

Direction change (review discussion, 2026-07-05): implement this inside the "Build Pattern Set…" modal rather than as a File ▾ one-click.

Rationale: the modal is already "this protocol's pattern set" (pick/validate/order UI + the active set that drives W badges), so collect is just seeding the set from the protocol's references, and colocate is just a second output next to Export ZIP. It also needs repo-awareness regardless — today its sources are built-in/remote-manifest/local-folder only, so course-repo patterns (patterns/ and _patterns/) are invisible to it.

Revised scope (v1):

1. New source: "course repo" — shared patterns/ + the current protocol's _patterns/, listed via the Contents API (no MANIFEST needed; the existing sources keep their manifest path).
2. "Add referenced" button — populate/select the set from the protocol's pattern: names, resolved across all sources; unresolved names reported loudly.
3. New output: "Commit set → protocols/<bench-id>/<name>_patterns/" beside Export ZIP — direct commit with the Promote-style hash guard (skip byte-identical, refuse same-name-different-content), then refresh the colocated listing (registerRepoPatternPreviews) so W badges update live.

v2 (separate, optional): "Upload set → SD" from the same modal via Studio.sdUploadFiles, making the modal the single pattern-set surface; ZIP export remains for offline/MATLAB benches.

Note: a File ▾ shortcut can always be added later as "open the modal pre-seeded" — the modal work is the foundation either way.

[mbreiser]

Implemented (v1 scope) on branch claude/competent-montalcini-076abe, commit 5a403e3 — Course repo source (patterns/ + the protocol's _patterns/), Add referenced with loud unresolved reporting, Commit set → repo with the identical-skip / different-refuse guard + live W-badge refresh. Verified against a stubbed GitHub layer; bench pass rides the v0.7 E2E checklist. Leaving open for the bench check + the possible v2 (SD-upload output from the same modal).