fix(dashboard): classify suffixed P3 protocol names from metadata - #180
Merged
Conversation
…0sTrain) from metadata The catalog classifies runs from run_metadata alone (no condition names yet); the P3 family regex required the filename to END in _short/_full, so rig-saved variants such as p3-heisenberg-ts-full-led8.yaml showed as "p3 legacy diagnostic" in the run list and protocol filter. Once loaded, the run was re-classified correctly from its condition names, so analysis numbers were never affected — this fixes the label/filter only. Tests added. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rig-saved P3 variants (
p3-heisenberg-ts-full-led8.yaml,…-full-led8-40sTrain.yaml,…-short-led5.yaml) showed as p3 legacy diagnostic in the dashboard's run list and protocol filter because the metadata-only classifier required the filename to end in_short/_full. The regex now allows trailing suffix segments.Analysis impact: none. Once a run is loaded,
protocolInfore-runs with the condition names (baseline_phase0…) and already classified these asp3-heisenberg-ts, non-legacy, so cue normalization and every P3 plot were correct. This only fixes the catalog label and the protocol filter grouping.Tests: metadata-only classification for four suffixed names (family, timing, non-legacy). Dashboard analysis suite green.
🤖 Generated with Claude Code