Check if invalid filepath specified then raise Exception#17
Merged
Conversation
yuki-mt
approved these changes
Nov 21, 2018
Member
yuki-mt
left a comment
There was a problem hiding this comment.
LGTM.
(As for readability, method name is_valid_upload_filename or something might be better than check_... because it explicitly describes return True is the file name is valid . very trivial, though)
Member
Author
|
@yuki-mt Thank you for the review. |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 85.87% 86.57% +0.69%
==========================================
Files 16 16
Lines 885 931 +46
==========================================
+ Hits 760 806 +46
Misses 125 125
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The current process allows to save files to the system file location when user specify the relative path via API. This PR checks the
filenameincludes filepath or not.This PR includes
What type of PR is it?
Bugfix
What is the issue?
#16
How should this be tested?