Skip to content

Conversation

@keigohtr
Copy link
Member

What is this PR for?

To access gRPC service through ingress-gateway, we need to specify host as [::].
For this, we need to configure insecure_host by environment variables.

This PR includes

  • Add service_insecure_host option

What type of PR is it?

Bugfix

What is the issue?

N/A

How should this be tested?

$ python -m unittest

@keigohtr keigohtr self-assigned this Feb 28, 2019
Copy link
Member

@yoquankara yoquankara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keigohtr keigohtr merged commit bd8d73b into master Feb 28, 2019
@keigohtr keigohtr deleted the fix/add-service-insecure-host-option branch February 28, 2019 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants