-
Notifications
You must be signed in to change notification settings - Fork 2
prevent OOM due to evaluation data #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bbb4bd0 to
505d8e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 88.06% 87.61% -0.46%
==========================================
Files 15 15
Lines 863 872 +9
==========================================
+ Hits 760 764 +4
- Misses 103 108 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM. Great work with you!
I made some questions, could you give me a feedback?
keigohtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
prevent OOM with large
List[EvaluateResultDetail]dataThis PR includes
evaluatemethod returns generator ofEvaluateResultDetail(and lastly return EvaluateResult)What type of PR is it?
Feature/Bugfix/....
What is the issue?
fixed #25
How should this be tested?
python -m unittest