chore: simplify Composer version constraints - #180
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The relaxed filament/filament: ^5.7 range can resolve to known-vulnerable Filament patches (<5.7.6) without an explicit Composer-level block in this package.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR simplifies Composer dependency version constraints by switching several dependencies from patch-specific caret constraints (e.g. ^5.7.8) to major.minor caret constraints (e.g. ^5.7), aiming to lower minimum patch requirements while keeping the same supported major/minor lines.
Changes:
- Loosened
spatie/laravel-package-toolsfrom^1.15.0to^1.15. - Loosened several
require-devconstraints (includingfilament/filament, Pest plugins, PHPStan tooling, Pint, Collision, Ray) to major.minor caret ranges.
File summaries
| File | Description |
|---|---|
| composer.json | Updates Composer version constraints to be less patch-specific, primarily in require-dev. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }, | ||
| "require-dev": { | ||
| "filament/filament": "^5.7.8", | ||
| "filament/filament": "^5.7", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use major.minor caret constraints for Composer dependencies, including
filament/filament: ^5.7instead of^5.7.8.This follows the common notation in Spatie's package tools and Filament Support.
Both projects also use patch-specific constraints where needed. Three-part constraints are valid Composer syntax, but they set a more restrictive minimum.
The changes lower development patch minimums while preserving supported major and minor lines.
spatie/laravel-package-tools: ^1.15is equivalent to^1.15.0.Runtime compatibility and npm dependencies remain unchanged.
Validation:
The broader
^5.7range also matches older vulnerable patches. Composer blocked the attempted 5.7.0 installation with its existing advisory protection.The older-version test therefore uses 5.7.6, which contains the MFA security fix. No advisory checks were disabled.