Adding xml-rpc exception to retry decorator #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@amcmahon-rh They were not there because they are not recoverable, as I understand it. Do you have any example where the retry would help after |
Contributor
|
ProtocolError is raised if the XML-RPC request gets an HTTP response of any status other than 200, so it may or may not be recoverable. A request failing due to temporary lack of resources on the server is an example where you may be able to recover by retrying. |
Contributor
|
@rohanpm You are right! Then it makes sense to retry the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML-RPC Protocol Error exceptions were not being caught by the retry decorator, so these errors weren't getting retried. Just need to add in the specific exception into the list of retried exceptions.