auth: make krb5login redirects safer#234
Merged
Merged
Conversation
Originally, the krb5login page would allow redirects to any URLs, e.g. to Google using http://$HOSTNAME/auth/krb5login/?next=//www.google.com. This commit implements similar sanitization of REDIRECT_FIELD_NAME like Django does in its LoginView. Related: https://github.com/django/django/blob/8fcb9f1f106cf60d953d88aeaa412cc625c60029/django/contrib/auth/views.py#L43C18-L43C18
lzaoral
force-pushed
the
safe-krb5-redirects
branch
from
1ca76a7 to
92c8099
Compare
rohanpm
reviewed
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the krb5login page would allow redirects to any URLs, e.g.
to Google using
http://$HOSTNAME/auth/krb5login/?next=//www.google.com.This commit implements similar sanitization of
REDIRECT_FIELD_NAMElike Django does in itsLoginView.Related: https://github.com/django/django/blob/8fcb9f1f106cf60d953d88aeaa412cc625c60029/django/contrib/auth/views.py#L43C18-L43C18