Notify the Homebrew tap on release, and drop the retired macos-13 runner - #29
Merged
Merged
Conversation
The tap bumps its formula from the published release. It polls daily, so this only shortens the delay -- which is why a missing token is a ::notice:: rather than a failure. GITHUB_TOKEN cannot dispatch to another repository, so this needs a HOMEBREW_TAP_TOKEN secret with 'contents: write' on releasetools/homebrew-tap; until one exists the step is a no-op and the release is unaffected. The tag is passed as client_payload.version so the tap bumps to the release that just shipped rather than whatever is newest when it wakes up. Separately, the test-platforms matrix still listed macos-13. GitHub has retired that image and the label no longer resolves to a runner, so that leg would fail to schedule -- actionlint rejects it against its current label list. Replaced with macos-26, which also matches the images the homebrew tap tests against. The v0.0.12 run predates the retirement, which is why this has not been seen yet. Also quoted the three '>> $GITHUB_ENV' redirections in the same file, which were actionlint's only other findings there. test-release.yaml is now clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
7 tasks
Contributor
Author
|
The Two reasons beyond the usual PAT objections:
This PR is still safe to merge as-is: with no secret set, the notify step logs a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two release-path fixes, plus the actionlint findings in the file they touch.
Notify the tap on release
releasetools/homebrew-tap#16 bumps the formula from the published release. It already polls daily, so this only shortens the delay — which is why a missing token is a
::notice::rather than a failure:GITHUB_TOKENcannot dispatch to another repository, so this needs aHOMEBREW_TAP_TOKENsecret withcontents: writeonreleasetools/homebrew-tap. Until one exists the step is a no-op — nothing here can break a release.The tag goes over as
client_payload.version, so the tap bumps to the release that just shipped rather than whatever is newest when it wakes up.Manual bumping is handled on the tap side by the
workflow_dispatchinput in releasetools/homebrew-tap#16 — optionalvX.Y.Z, defaulting to the newest release.Drop the retired macos-13 runner
test-platformsstill listedmacos-13. GitHub has retired that image, so the label no longer resolves to a runner and the leg would fail to schedule. actionlint rejects it against its current label list:The last
test-releaserun (v0.0.12, 2025-09-06) predates the retirement and passed, which is why this hasn't bitten yet — it would bite on the next release.Replaced with
macos-26, which also matches the images the homebrew tap tests against, so the two repos now cover the same macOS set.Also
Quoted the three
>> $GITHUB_ENVredirections in the same file — actionlint's only other findings there. Both workflows are now clean:make testpasses;shellcheckclean.🤖 Generated with Claude Code