new 45/NPi+NDC with EUR 2030, ELEVATE2p3 config, fix coupled tests, adjust units 2005->2017 - #1851
Merged
Merged
Conversation
orichters
marked this pull request as draft
October 1, 2024 11:26
orichters
force-pushed
the
elevateclean
branch
from
October 4, 2024 15:41
550cfed to
0d12430
Compare
orichters
marked this pull request as ready for review
October 7, 2024 06:01
orichters
force-pushed
the
elevateclean
branch
from
October 7, 2024 06:03
ceb3e96 to
6256bfe
Compare
RahelMA
approved these changes
Oct 7, 2024
laurinks
reviewed
Oct 7, 2024
laurinks
reviewed
Oct 7, 2024
laurinks
reviewed
Oct 7, 2024
LaviniaBaumstark
approved these changes
Oct 7, 2024
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
make test-fixand./scripts/utils/SOFEOFnow automatically corrects wrong filenamesmake test-coupledbecause the calibration uses regipol, but the test setting not, which lead to problems because somev47_variable recently introduced failedType of change
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctly