Skip to content

fail if coupled config has path_gdx_ref column but not path_gdx_refpolicycost - #1940

Merged
orichters merged 4 commits into
remindmodel:developfrom
orichters:develop
Jan 7, 2025
Merged

fail if coupled config has path_gdx_ref column but not path_gdx_refpolicycost#1940
orichters merged 4 commits into
remindmodel:developfrom
orichters:develop

Conversation

@orichters

Copy link
Copy Markdown
Contributor

Purpose of this PR

  • When reading a config file and path_gdx_ref is specified but path_gdx_refpolicycost isn't, it just copies it over, which makes sense. But that means: if you specify path_gdx_ref and path_gdx_refpolicycost separately in the normal config file, but only path_gdx_ref in the coupled config file, then path_gdx_ref from the coupled config is used to overwrite path_gdx_refpolicycost, which I didn't expect and it created an error in the NGFS scenarios. The problem is that the way the code is written, the coupled config cannot know at this point whether the column exist in the other config file.
  • Therefore, start_bundle_coupled.R now fails if path_gdx_ref exists in the coupled config, but not the path_gdx_refpolicycost column.
  • Adapted all the existing config files
  • removed GCS coupled config that @gabriel-abrahao said was not needed anymore.
  • reduce default runtime in tests to 20 hours to make sure the test slurm of make test-full-slurm is not running into a timeout because the default takes too long.

Type of change

  • Bug fix
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I did not adjusted the reporting in remind2 as it wasn't needed
  • I did not adjust forbiddenColumnNames in readCheckScenarioConfig.R
  • All automated model tests pass (FAIL 0 in the output of make test and make test-coupled)
  • The changelog CHANGELOG.md has been updated correctly

@orichters
orichters requested a review from dklein-pik January 6, 2025 14:07

@dklein-pik dklein-pik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@orichters
orichters merged commit 2f61bed into remindmodel:develop Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants