fail if coupled config has path_gdx_ref column but not path_gdx_refpolicycost - #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
path_gdx_refis specified butpath_gdx_refpolicycostisn't, it just copies it over, which makes sense. But that means: if you specifypath_gdx_refandpath_gdx_refpolicycostseparately in the normal config file, but onlypath_gdx_refin the coupled config file, thenpath_gdx_reffrom the coupled config is used to overwritepath_gdx_refpolicycost, which I didn't expect and it created an error in the NGFS scenarios. The problem is that the way the code is written, the coupled config cannot know at this point whether the column exist in the other config file.start_bundle_coupled.Rnow fails ifpath_gdx_refexists in the coupled config, but not thepath_gdx_refpolicycostcolumn.make test-full-slurmis not running into a timeout because the default takes too long.Type of change
Checklist:
remind2as it wasn't neededforbiddenColumnNamesin readCheckScenarioConfig.RFAIL 0in the output ofmake testandmake test-coupled)CHANGELOG.mdhas been updated correctly