refactor GDP and population switches - #1973
Merged
LaviniaBaumstark merged 31 commits intoFeb 7, 2025
Merged
Conversation
all_POPscen, all_GDPscen -> all_GDPpopScen, remove prefix "gdp_" and "pop_" and cm_POPscen, cm_GDPscen, c_GDPpcScen -> cm_GDPpopScen
| @@ -96,6 +36,35 @@ a1 | |||
| a2 | |||
Contributor
There was a problem hiding this comment.
Can the a1, a2, b1, b2, and SSP2EU scenarios be removed perhaps?
Contributor
There was a problem hiding this comment.
I think that in the new input data the scenario gdp_SSP2EU_NAV_all is now called SSP2_NAV_all (so no more SSP2EU).
johanneskoch94
approved these changes
Feb 7, 2025
johanneskoch94
left a comment
johanneskoch94
left a comment
Contributor
There was a problem hiding this comment.
Thanks! See the 2 comments for possible additional changes :)
10 tasks
LaviniaBaumstark
added a commit
to LaviniaBaumstark/remind2
that referenced
this pull request
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Type of change
Checklist:
forbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information (optional):