Skip to content

add REMIND-MAgPIE compatibility test, remove last traces of SSP2EU - #2028

Merged
orichters merged 10 commits into
remindmodel:developfrom
orichters:develop
Mar 10, 2025
Merged

add REMIND-MAgPIE compatibility test, remove last traces of SSP2EU#2028
orichters merged 10 commits into
remindmodel:developfrom
orichters:develop

Conversation

@orichters

@orichters orichters commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

  • remove last traces of SSP2EU in order not to confuse our magpie collagues
  • add a check that check consistency across REMIND and MAgPIE:
    • population and GDP scenarios
    • if REMIND climate damages are on, then also MAgPIE needs climate damages
    • bioenergy phaseout is in both models simultaneously either on or off
  • close add REMIND-MAgPIE compatibility test, remove last traces of SSP2EU #2028

It does the following: In MAgPIE, there seems to be cfg_mag$gms$c09_pop_scenario and ...$c09_gdp_scenario with those options:

SDP, SDP_EI, SDP_MC, SDP_RC, SSP1, SSP2, SP3, SSP4, SSP5, SSP2EU

In REMIND, we had cfg_rem$gms$cm_GDPpopScen with those options:

SDP_EI, SDP_MC, SDP_RC, SSP1, SSP2, SSP2EU, SSP3, SSP4, SSP5, SSP2IndiaMedium, SSP2IndiaHigh

First of all, I removed the last traces of SSP2EU as it is not in any input file anyhow. grep -d skip SSPEU * */* */*/* */*/*/* */*/*/*/* */*/*/*/*/* does not show any trace of it anymore, so it can be deleted.

This check checks whether if those things start with SSP? or SDP_??, then they must all be identical. So SSP2IndiaHigh in REMIND, SSP2EU in MAgPIE -> works. But SDP_EI in REMIND and SDP_MC in MAgPIE doesn't.

For bioenergy, I followed @merfort's suggestions here: https://github.com/remindmodel/development_issues/issues/521

For damages, I agreed with @piontek that currently all REMIND damage implementations need MAgPIE damages as well. In case this might change, I added an explanation how to exclude it from the check

At the moment, the ScenarioMIP coupled config is erroneous with this check, but @laurinks is aware and wants to fix it on the MAgPIE side.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I checked the log.txt file of my runs for newly introduced summation, fixing or variable name errors
  • All automated model tests pass, executed after my final commit (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@dklein-pik dklein-pik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@orichters
orichters marked this pull request as ready for review March 10, 2025 10:15
@laurinks

Copy link
Copy Markdown
Contributor

Thanks for this useful PR, @orichters ! As I wrote here, I have no objections and the three inconsistencies that you identified will need to be corrected for the next round of ScenarioMIP runs. As I said, it would be great to have the list of consistent REMIND-MAgPIE combinations in the main.gms in REMIND. Moreover, I would recommend to ask @flohump to double-check it. Thanks!

@FelicitasBeier

Copy link
Copy Markdown
Contributor

A side-question: If I remember correctly, we said in the coupling channel (https://mattermost.pik-potsdam.de/rd3/channels/remind-magpie-coupling) in January that the SSP2EU should be removed.
Sorry, we haven't done that for MAgPIE. Somehow slipped through, but now that it's in the list, I remembered.

Anyhow, just to clarify since I see here that it's still part of cfg_rem$gms$cm_GDPpopScen in REMIND.
If we remove it / replace SSP2 with SSP2EU, should we remove from both cfg_mag$gms$c09_pop_scenario and cfg_mag$gms$c09_gdp_scenario, or should the pop_scenario be kept for some reason?

@orichters

Copy link
Copy Markdown
Contributor Author

A side-question: If I remember correctly, we said in the coupling channel (https://mattermost.pik-potsdam.de/rd3/channels/remind-magpie-coupling) in January that the SSP2EU should be removed. Sorry, we haven't done that for MAgPIE. Somehow slipped through, but now that it's in the list, I remembered.

Anyhow, just to clarify since I see here that it's still part of cfg_rem$gms$cm_GDPpopScen in REMIND. If we remove it / replace SSP2 with SSP2EU, should we remove from both cfg_mag$gms$c09_pop_scenario and cfg_mag$gms$c09_gdp_scenario, or should the pop_scenario be kept for some reason?

In REMIND input data, SSP2 und SSP2EU are identical, the latter was kept purely for backwards compatibility and I think it should be removed. I added a check to main.gms to make sure it cannot be used anymore.

@orichters orichters changed the title add REMIND-MAgPIE compatibility test add REMIND-MAgPIE compatibility test, remove last traces of SSP2EU Mar 10, 2025
Comment thread main.gms
*' * (SDP|SDP_EI|SDP_MC|SDP_RC): SDP scenarios
*' * (SSP2IndiaMedium|SSP2IndiaHigh): special India scenario
$setglobal cm_GDPpopScen SSP2 !! def = SSP2 !! regexp = SSP[1-5]|SDP(_EI|_MC|_RC)?|SSP2IndiaMedium|SSP2IndiaHigh
*' c_techAssumptScen flag defines an energy technology scenario according to SSP narratives

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants