add REMIND-MAgPIE compatibility test, remove last traces of SSP2EU - #2028
Conversation
dklein-pik
left a comment
There was a problem hiding this comment.
Looks good. Thank you!
|
Thanks for this useful PR, @orichters ! As I wrote here, I have no objections and the three inconsistencies that you identified will need to be corrected for the next round of ScenarioMIP runs. As I said, it would be great to have the list of consistent REMIND-MAgPIE combinations in the main.gms in REMIND. Moreover, I would recommend to ask @flohump to double-check it. Thanks! |
|
A side-question: If I remember correctly, we said in the coupling channel (https://mattermost.pik-potsdam.de/rd3/channels/remind-magpie-coupling) in January that the SSP2EU should be removed. Anyhow, just to clarify since I see here that it's still part of cfg_rem$gms$cm_GDPpopScen in REMIND. |
In REMIND input data, SSP2 und SSP2EU are identical, the latter was kept purely for backwards compatibility and I think it should be removed. I added a check to main.gms to make sure it cannot be used anymore. |
| *' * (SDP|SDP_EI|SDP_MC|SDP_RC): SDP scenarios | ||
| *' * (SSP2IndiaMedium|SSP2IndiaHigh): special India scenario | ||
| $setglobal cm_GDPpopScen SSP2 !! def = SSP2 !! regexp = SSP[1-5]|SDP(_EI|_MC|_RC)?|SSP2IndiaMedium|SSP2IndiaHigh | ||
| *' c_techAssumptScen flag defines an energy technology scenario according to SSP narratives |
Purpose of this PR
SSP2EUin order not to confuse our magpie collaguesIt does the following: In MAgPIE, there seems to be
cfg_mag$gms$c09_pop_scenarioand...$c09_gdp_scenariowith those options:In REMIND, we had
cfg_rem$gms$cm_GDPpopScenwith those options:First of all, I removed the last traces of
SSP2EUas it is not in any input file anyhow.grep -d skip SSPEU * */* */*/* */*/*/* */*/*/*/* */*/*/*/*/*does not show any trace of it anymore, so it can be deleted.This check checks whether if those things start with
SSP?orSDP_??, then they must all be identical. So SSP2IndiaHigh in REMIND, SSP2EU in MAgPIE -> works. ButSDP_EIin REMIND andSDP_MCin MAgPIE doesn't.For bioenergy, I followed @merfort's suggestions here: https://github.com/remindmodel/development_issues/issues/521
For damages, I agreed with @piontek that currently all REMIND damage implementations need MAgPIE damages as well. In case this might change, I added an explanation how to exclude it from the check
At the moment, the ScenarioMIP coupled config is erroneous with this check, but @laurinks is aware and wants to fix it on the MAgPIE side.
Type of change
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switcheslog.txtfile of my runs for newly introduced summation, fixing or variable name errorsFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctly