Skip to content

fix bug in RIKEN config, let 45/none set carbonprices to 0 only for t, not ttot - #2056

Merged
orichters merged 4 commits into
remindmodel:developfrom
orichters:riken
Mar 26, 2025
Merged

fix bug in RIKEN config, let 45/none set carbonprices to 0 only for t, not ttot#2056
orichters merged 4 commits into
remindmodel:developfrom
orichters:riken

Conversation

@orichters

@orichters orichters commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

  • let RIKEN KLW runs use none for carbon prices, still, 21_tax datainput guarantees non-zero taxes pre cm_startyear.
  • sort runs and add description
  • avoid that they are set to 0 in 45/none/datainput

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I checked the log.txt file of my runs for newly introduced summation, fixing or variable name errors
  • All automated model tests pass, executed after my final commit (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@orichters
orichters marked this pull request as ready for review March 26, 2025 08:04
@orichters
orichters requested a review from lena-kilian March 26, 2025 08:04
@orichters
orichters merged commit 06c10fa into remindmodel:develop Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants